Issue 173381: Group and triage HTML5 media layout tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 173381: Group and triage HTML5 media layout tests (Closed)

Created:
11 years, 4 months ago by dglazkov

Modified:
9 years, 6 months ago

Reviewers:
scherkus (not reviewing)

CC:
chromium-reviews_googlegroups.com, darin (slow to review)

Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/

Visibility:
Public.

Description

Group and triage HTML5 media layout tests R=scherkus TEST=none BUG=16779 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24447

Patch Set 1 #

Total comments: 7

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+84 lines, -89 lines)			Patch
	M	webkit/tools/layout_tests/test_expectations.txt	View		13 chunks	+84 lines, -89 lines	7 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scherkus (not reviewing)

LGTM, bunch of nits but nothing serious thanks for doing this! http://codereview.chromium.org/173381/diff/1/2 File webkit/tools/layout_tests/test_expectations.txt (right): ...

11 years, 4 months ago (2009-08-25 20:41:09 UTC) #2

dglazkov

11 years, 4 months ago (2009-08-26 15:48:53 UTC) #3

Thanks for looking through it!

http://codereview.chromium.org/173381/diff/1/2
File webkit/tools/layout_tests/test_expectations.txt (right):

http://codereview.chromium.org/173381/diff/1/2#newcode666
Line 666: 
On 2009/08/25 20:41:09, scherkus wrote:
> nit: remove extra blank line

Done.

http://codereview.chromium.org/173381/diff/1/2#newcode2762
Line 2762: 
On 2009/08/25 20:41:09, scherkus wrote:
> nit: remove extra blank line

Done.

http://codereview.chromium.org/173381/diff/1/2#newcode2792
Line 2792: 
On 2009/08/25 20:41:09, scherkus wrote:
> nit: remove extra blank line

Done.

Expand Messages | Collapse Messages