Add a helper to resource bundle to get an NSImage back....

Add a helper to resource bundle to get an NSImage back.
skia/ext/skia_utils_mac.h includes CoreGraphics/CGColor.h so we have to relay the framework include path so someone can include the header without errors.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24453

[TVL, 2009-08-25 18:42:32]

Sending this out as it's won CL so the helper can be used by other folks while I
continue what I was working on.

The new helper is sorta related to http://crbug.com/20230

[Mark Mentovai, 2009-08-25 19:05:01]

http://codereview.chromium.org/173363/diff/1/2
File app/resource_bundle.h (right):

http://codereview.chromium.org/173363/diff/1/2#newcode124
Line 124: // Wrapper for GetBitmapNamed converts the bitmap to an NSImage.
New sentence beginning with "converts."

http://codereview.chromium.org/173363/diff/1/4
File skia/skia.gyp (right):

http://codereview.chromium.org/173363/diff/1/4#newcode648
Line 648:
'$(SDKROOT)/System/Library/Frameworks/ApplicationServices.framework/Frameworks',
What's this needed for?

I want to eliminate all of these.

[TVL, 2009-08-25 19:11:02]

http://codereview.chromium.org/173363/diff/1/4
File skia/skia.gyp (right):

http://codereview.chromium.org/173363/diff/1/4#newcode648
Line 648:
'$(SDKROOT)/System/Library/Frameworks/ApplicationServices.framework/Frameworks',
On 2009/08/25 19:05:01, Mark Mentovai wrote:
> What's this needed for?
> 
> I want to eliminate all of these.

from cl description:
skia/ext/skia_utils_mac.h includes CoreGraphics/CGColor.h so we have to relay
the framework include path so someone can include the header without errors.

[Avi (use Gerrit), 2009-08-25 19:16:07]

http://codereview.chromium.org/173363/diff/1/2
File app/resource_bundle.h (right):

http://codereview.chromium.org/173363/diff/1/2#newcode124
Line 124: // Wrapper for GetBitmapNamed converts the bitmap to an NSImage.
Personal preference: can we note that the NSImage is autoreleased?

[TVL, 2009-08-26 14:08:34]

nudge

[Mark Mentovai, 2009-08-26 15:15:24]

LG

[Avi (use Gerrit), 2009-08-26 16:56:43]

On 2009/08/26 15:15:24, Mark Mentovai wrote:
> LG

LG