Issue 173345: Reverting 24220.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 173345: Reverting 24220. (Closed)

Created:
11 years, 3 months ago by Yuta Kitamura

Modified:
9 years, 7 months ago

Reviewers:
Lei Zhang

CC:
chromium-reviews_googlegroups.com, darin (slow to review), brettw, jam, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Reverting 24220. It seemed that r24220 caused failures on all of Linux UI (valgrind) bots. TBR=thestig@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24228

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+63 lines, -117 lines)			Patch
M	breakpad/breakpad.gyp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	build/common.gypi	View	5 chunks	+8 lines, -20 lines	0 comments	Download
M	chrome/app/breakpad_linux.h	View	2 chunks	+2 lines, -5 lines	0 comments	Download
M	chrome/app/breakpad_linux.cc	View	15 chunks	+34 lines, -74 lines	0 comments	Download
M	chrome/browser/renderer_host/render_crash_handler_host_linux.cc	View	4 chunks	+2 lines, -14 lines	0 comments	Download
M	chrome/chrome.gyp	View	1 chunk	+14 lines, -0 lines	0 comments	Download
M	chrome/common/child_process_host.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

Lei Zhang

11 years, 3 months ago (2009-08-25 18:23:37 UTC) #2

On 2009/08/25 11:17:41, Yuta Kitamura wrote:
> 

Thanks. It looked like everything was going to go green...