Issue 173341: Autofill http auth dialog on os x and linux.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 173341: Autofill http auth dialog on os x and linux. (Closed)

Created:
11 years, 4 months ago by Nico

Modified:
9 years, 7 months ago

Reviewers:
stuartmorgan, Elliot Glaysher

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Autofill http auth dialog on os x and linux. BUG=19801 TEST=See bug (on both mac and linux) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24241

Patch Set 2 : os x actually compiles and works #

Patch Set 3 : linux compiles and works #

Total comments: 1

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+75 lines, -7 lines)			Patch
M	chrome/browser/login_prompt_gtk.cc	View	1 2	6 chunks	+33 lines, -2 lines	0 comments	Download
M	chrome/browser/login_prompt_mac.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/login_prompt_mac.mm	View	1	7 chunks	+40 lines, -4 lines	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

stuartmorgan

http://codereview.chromium.org/173341/diff/1005/1008 File chrome/browser/login_prompt_mac.mm (right): http://codereview.chromium.org/173341/diff/1005/1008#newcode337 Line 337: if ([[nameField_ stringValue] length] == 0) { Per ...

11 years, 4 months ago (2009-08-25 16:54:39 UTC) #3

stuartmorgan

Apparently I misremembered; thanks for testing! LGTM

11 years, 4 months ago (2009-08-25 17:06:07 UTC) #4

Nico

11 years, 4 months ago (2009-08-25 17:08:05 UTC) #5

For the records, the relevant bit from irc: """i put in a
"performSelector:afterDelay:1.0" and tested a) opening the sheet and typing some
text and b) not typing anyting and waiting for a second. in case a), my typing
is not overwritten, but in case b) the field is filled in. so this works as it
should"""