Issue 173339: DevTools: make "Take snapshot" button in heap profiler visible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 173339: DevTools: make "Take snapshot" button in heap profiler visible. (Closed)

Created:
11 years, 4 months ago by mnaganov (inactive)

Modified:
9 years, 7 months ago

Reviewers:
pfeldman

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

DevTools: make "Take snapshot" button in heap profiler visible. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24219

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -10 lines)			Patch
	M	webkit/glue/devtools/js/devtools.css	View		1 chunk	+2 lines, -6 lines	0 comments	Download
	M	webkit/glue/devtools/js/heap_profiler_panel.js	View		2 chunks	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

pfeldman

On 2009/08/25 06:37:46, Michail Naganov wrote: > LGTM Are you planning to migrate to the ...

11 years, 4 months ago (2009-08-25 07:08:50 UTC) #2

mnaganov (inactive)

11 years, 4 months ago (2009-08-25 07:12:16 UTC) #3

On 2009/08/25 07:08:50, pfeldman wrote:
> On 2009/08/25 06:37:46, Michail Naganov wrote:
> > 
> 
> LGTM
> 
> Are you planning to migrate to the single-panel approach? I think we should do
> that before adding more features.

Sure, but this one is a fix, not a feature.

Expand Messages | Collapse Messages