Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7122)

Unified Diff: chrome/browser/sync/glue/http_bridge.h

Issue 173325: Make HttpBridge::AllowSendingCookies return true for now.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/sync/glue/http_bridge_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/glue/http_bridge.h
===================================================================
--- chrome/browser/sync/glue/http_bridge.h (revision 24204)
+++ chrome/browser/sync/glue/http_bridge.h (working copy)
@@ -63,7 +63,9 @@
}
virtual bool AllowSendingCookies(const URLRequest* request) const {
- return false; // Never send cookies.
+ // TODO(chron): http://crbug.com/20182. Change this to return false once
+ // all clients use Authenticate: header auth mode.
+ return true;
}
private:
@@ -83,6 +85,11 @@
const char* content);
virtual void AddCookieForRequest(const char* cookie);
virtual bool MakeSynchronousPost(int* os_error_code, int* response_code);
+
+ // WARNING: these response content methods are used to extract plain old data
+ // and not null terminated strings, so you should make sure you have read
+ // GetResponseContentLength() characters when using GetResponseContent. e.g
+ // string r(b->GetResponseContent(), b->GetResponseContentLength()).
virtual int GetResponseContentLength() const;
virtual const char* GetResponseContent() const;
virtual int GetResponseCookieCount() const;
« no previous file with comments | « no previous file | chrome/browser/sync/glue/http_bridge_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698