Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Side by Side Diff: chrome/browser/sync/glue/http_bridge_unittest.cc

Issue 173325: Make HttpBridge::AllowSendingCookies return true for now.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/sync/glue/http_bridge.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifdef CHROME_PERSONALIZATION 5 #ifdef CHROME_PERSONALIZATION
6 6
7 #include "base/thread.h" 7 #include "base/thread.h"
8 #include "chrome/browser/sync/glue/http_bridge.h" 8 #include "chrome/browser/sync/glue/http_bridge.h"
9 #include "net/url_request/url_request_unittest.h" 9 #include "net/url_request/url_request_unittest.h"
10 #include "testing/gtest/include/gtest/gtest.h" 10 #include "testing/gtest/include/gtest/gtest.h"
(...skipping 140 matching lines...) Expand 10 before | Expand all | Expand 10 after
151 151
152 int os_error = 0; 152 int os_error = 0;
153 int response_code = 0; 153 int response_code = 0;
154 bool success = http_bridge->MakeSynchronousPost(&os_error, &response_code); 154 bool success = http_bridge->MakeSynchronousPost(&os_error, &response_code);
155 EXPECT_TRUE(success); 155 EXPECT_TRUE(success);
156 EXPECT_EQ(200, response_code); 156 EXPECT_EQ(200, response_code);
157 EXPECT_EQ(0, os_error); 157 EXPECT_EQ(0, os_error);
158 EXPECT_EQ(0, http_bridge->GetResponseCookieCount()); 158 EXPECT_EQ(0, http_bridge->GetResponseCookieCount());
159 std::string response(http_bridge->GetResponseContent(), 159 std::string response(http_bridge->GetResponseContent(),
160 http_bridge->GetResponseContentLength()); 160 http_bridge->GetResponseContentLength());
161 161 #if BUG_20182_FIXED
162 // TODO(chron): Re-enable this expectation.
162 EXPECT_EQ(std::string::npos, response.find("Cookie:")); 163 EXPECT_EQ(std::string::npos, response.find("Cookie:"));
164 #else
165 EXPECT_NE(std::string::npos, response.find("Cookie:"));
166 #endif
163 EXPECT_NE(std::string::npos, response.find("User-Agent: bob")); 167 EXPECT_NE(std::string::npos, response.find("User-Agent: bob"));
164 EXPECT_NE(std::string::npos, response.find(test_payload.c_str())); 168 EXPECT_NE(std::string::npos, response.find(test_payload.c_str()));
165 } 169 }
166 170
167 TEST_F(HttpBridgeTest, TestExtraRequestHeaders) { 171 TEST_F(HttpBridgeTest, TestExtraRequestHeaders) {
168 scoped_refptr<HTTPTestServer> server = HTTPTestServer::CreateServer(kDocRoot, 172 scoped_refptr<HTTPTestServer> server = HTTPTestServer::CreateServer(kDocRoot,
169 NULL); 173 NULL);
170 ASSERT_TRUE(NULL != server.get()); 174 ASSERT_TRUE(NULL != server.get());
171 scoped_refptr<HttpBridge> http_bridge(BuildBridge()); 175 scoped_refptr<HttpBridge> http_bridge(BuildBridge());
172 176
(...skipping 14 matching lines...) Expand all
187 EXPECT_EQ(0, os_error); 191 EXPECT_EQ(0, os_error);
188 EXPECT_EQ(0, http_bridge->GetResponseCookieCount()); 192 EXPECT_EQ(0, http_bridge->GetResponseCookieCount());
189 std::string response(http_bridge->GetResponseContent(), 193 std::string response(http_bridge->GetResponseContent(),
190 http_bridge->GetResponseContentLength()); 194 http_bridge->GetResponseContentLength());
191 195
192 EXPECT_NE(std::string::npos, response.find("fnord")); 196 EXPECT_NE(std::string::npos, response.find("fnord"));
193 EXPECT_NE(std::string::npos, response.find(test_payload.c_str())); 197 EXPECT_NE(std::string::npos, response.find(test_payload.c_str()));
194 } 198 }
195 199
196 #endif // CHROME_PERSONALIZATION 200 #endif // CHROME_PERSONALIZATION
OLDNEW
« no previous file with comments | « chrome/browser/sync/glue/http_bridge.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698