Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 173324: Fix double control key issue with the omnibox. (Closed)

Created:
11 years, 4 months ago by Dean McNamee
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews_googlegroups.com, James Su
Visibility:
Public.

Description

Fix double control key issue with the omnibox. Previously holding two controls keys and releasing one would show the non-control omnibox results, but hitting enter would take the control results. Fix this by showing the correct results if any control key is held down.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc View 1 chunk +10 lines, -4 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
Dean McNamee
11 years, 4 months ago (2009-08-25 00:54:09 UTC) #1
Evan Martin
11 years, 4 months ago (2009-08-25 01:03:50 UTC) #2
LGTM

http://codereview.chromium.org/173324/diff/1/2
File chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc (right):

http://codereview.chromium.org/173324/diff/1/2#newcode666
Line 666: // Round trip to query the control state after the release.  This
allows
Maybe mention that |event| still thinks control is down.

Powered by Google App Engine
This is Rietveld 408576698