Issue 173314: Fix "crashed extension" infobar browser crashes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 173314: Fix "crashed extension" infobar browser crashes. (Closed)

Created:
11 years, 4 months ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
Aaron Boodman

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Fix "crashed extension" infobar browser crashes. This is a general rework of how "crashed extension" infobar works and how the extension is actually recovered after the crash. This is a subset of original http://codereview.chromium.org/164151/ . I had to remove the part which unloads the entire extension on crash, because it interacts badly with other parts of the browser. I'm fixing that. TEST=See bug. http://crbug.com/15888 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24231

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+144 lines, -97 lines)			Patch
M	chrome/app/generated_resources.grd	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/browser.cc	View	3 chunks	+15 lines, -0 lines	0 comments	Download
A	chrome/browser/extensions/crashed_extension_infobar.h	View	1 chunk	+46 lines, -0 lines	0 comments	Download
A	chrome/browser/extensions/crashed_extension_infobar.cc	View	1 chunk	+56 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_host.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/extensions/extension_host.cc	View	5 chunks	+1 line, -76 lines	0 comments	Download
M	chrome/browser/extensions/extension_prefs.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_prefs.cc	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extensions_service.cc	View	2 chunks	+6 lines, -5 lines	0 comments	Download
M	chrome/browser/views/extensions/extension_view.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/views/extensions/extension_view.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/chrome.gyp	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/common/notification_type.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages