Linux: set the initial size of the "Page" column in the task manager to fit the dialog.

Linux: set the initial size of the "Page" column in the task manager to fit the dialog.
This keeps that column from forcing the other columns into a scroll bar when a page with a long title is viewed.
BUG=17930
TEST=none

[James Hawkins, 2009-08-24 22:53:49]

http://codereview.chromium.org/173308/diff/1/2
File chrome/browser/gtk/task_manager_gtk.cc (right):

http://codereview.chromium.org/173308/diff/1/2#newcode33
Line 33: const int kPageColumnInitialSize = 270;
You should store the default page column size set by gtk by hooking up to the
realize event for |treeview_| and calling gtk_tree_view_column_get_width for the
first column instead of hardcoding the value.

http://codereview.chromium.org/173308/diff/1/2#newcode615
Line 615: placement_pref->SetInteger(L"page_column_width", page_column_width);
Do we really want to set a placement pref for this?  The page column should be
allocated to fill up all the remaining space in the treeview header (minus the
size of the right-most columns).  This will differ if the user changes the size
of the task manager.

[James Hawkins, 2009-08-25 01:09:03]

Sorry, I thought I had already pushed these comments out.

The BUG= should be 17930

http://codereview.chromium.org/173308/diff/1003/1004
File chrome/browser/gtk/task_manager_gtk.cc (right):

http://codereview.chromium.org/173308/diff/1003/1004#newcode621
Line 621: // Subtract 1 to work around some sort of fencepost error in GTK.
What's the problem from gtk here?  I mean, how are you seeing an off-by-one
error?

http://codereview.chromium.org/173308/diff/1003/1004#newcode627
Line 627: // This is a hack. Ideally we'd call gtk_tree_view_column_set_width(),
but
Can you factor this out into the TreeViewColumnSetWidth function?  That'll keep
the hackiness contained in a nice abstraction.

[James Hawkins, 2009-08-25 02:52:54]

LGTM

http://codereview.chromium.org/173308/diff/13/14
File chrome/browser/gtk/task_manager_gtk.cc (right):

http://codereview.chromium.org/173308/diff/13/14#newcode615
Line 615: namespace {
Please add this function to the anonymous namespace at the top of the file.