Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 1733020: ffmpeg disable zlib explicitely in the configuration (Closed)

Created:
10 years, 8 months ago by fbarchard
Modified:
9 years, 7 months ago
CC:
chromium-reviews, awong, Alpha Left Google
Visibility:
Public.

Description

ffmpeg disable zlib explicitely in the configuration BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45733

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/ffmpeg/source/config/Chrome/win/ia32/config.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/ffmpeg/source/config/Chromium/win/ia32/config.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
fbarchard
turning off zlib for windows explicitly (was implicitly off before) also remove -O2 since configure ...
10 years, 8 months ago (2010-04-27 01:05:27 UTC) #1
fbarchard
Care to review this Dave?
10 years, 8 months ago (2010-04-27 17:58:56 UTC) #2
davej
LGTM
10 years, 8 months ago (2010-04-27 18:08:59 UTC) #3
scherkus (not reviewing)
why are we loosing --extra-cflags=O2?
10 years, 8 months ago (2010-04-27 18:29:56 UTC) #4
fbarchard
On 2010/04/27 18:29:56, scherkus wrote: > why are we loosing --extra-cflags=O2? its ignored. I added ...
10 years, 8 months ago (2010-04-27 18:48:02 UTC) #5
scherkus (not reviewing)
10 years, 8 months ago (2010-04-27 19:01:41 UTC) #6
cool!

LGTM

Powered by Google App Engine
This is Rietveld 408576698