Issue 1733014: Fix the space bar to insert spaces in ibus-chewing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1733014: Fix the space bar to insert spaces in ibus-chewing (Closed)

Created:
10 years, 8 months ago by Zachary Kuznia

Modified:
9 years, 7 months ago

Reviewers:
Yusuke Sato

CC:
chromium-os-reviews_chromium.org

Visibility:
Public.

Description

This will cause the space bar to insert spaces if you aren't selecting a character. It is based on a patch written for ArchLinux: http://aur.archlinux.org/packages.php?ID=20567 BUG=chromium-os:1253 TEST=Set the input method to chewing, and try typing a space while not selecting a candidate. Ensure that a space is output.

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Fix preference loading #

Patch Set 4 : Remove preference patch. #

Patch Set 5 : Code Review #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -11 lines)			Patch
M	src/IBusChewingEngine.gob	View	1 2 3	9 chunks	+23 lines, -6 lines	0 comments	Download
M	src/IBusChewingEngine-def.c	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/IBusChewingEngine-keys.c	View		5 chunks	+24 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages