Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 173294: Don't copy the ENV variable from the users's external environment into... (Closed)

Created:
11 years, 4 months ago by sgk
Modified:
9 years, 5 months ago
CC:
v8-dev, Mark Mentovai
Visibility:
Public.

Description

Don't copy the ENV variable from the users's external environment into construction environments. SCons uses this as a dictionary of environment values for the commands it executes. BUG=none TEST=build with the variable ENV set in the user environment

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M SConstruct View 1 chunk +10 lines, -1 line 1 comment Download

Messages

Total messages: 2 (0 generated)
sgk
Mark Mentovai ran into this; he sets a variable named ENV in his environment, and ...
11 years, 4 months ago (2009-08-24 20:42:59 UTC) #1
Mads Ager (chromium)
11 years, 4 months ago (2009-08-25 06:29:05 UTC) #2
Thanks for the patch, I will land it.

http://codereview.chromium.org/173294/diff/1/2
File SConstruct (right):

http://codereview.chromium.org/173294/diff/1/2#newcode806
Line 806: sample_flags = context.AddRelevantFlags(os.environ, SAMPLE_FLAGS)
Should use |user_environ| here as well.

Powered by Google App Engine
This is Rietveld 408576698