Issue 173284: Introduce "testFunction" to reduce boilerplate in extensions API tests....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 173284: Introduce "testFunction" to reduce boilerplate in extensions API tests.... (Closed)

Created:
11 years, 4 months ago by asargent_no_longer_on_chrome

Modified:
9 years, 7 months ago

Reviewers:
Erik does not do reviews

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Introduce "testFunction" to reduce boilerplate in extensions API tests. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24232

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+204 lines, -189 lines)			Patch
	MM	chrome/test/data/extensions/api_test/bookmarks/api_test.js	View	1	1 chunk	+107 lines, -82 lines	0 comments	Download
	MM	chrome/test/data/extensions/api_test/bookmarks/test.js	View	1	1 chunk	+97 lines, -107 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Erik does not do reviews

11 years, 4 months ago (2009-08-24 19:46:12 UTC) #2

LGTM

http://codereview.chromium.org/173284/diff/1/2
File chrome/test/data/extensions/api_test/bookmarks/api_test.js (right):

http://codereview.chromium.org/173284/diff/1/2#newcode89
Line 89: func.apply(null, arguments);
wrap this in a try/catch and fail if an exception is thrown

Expand Messages | Collapse Messages