Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 173263: Change the way json_schema.js is loaded. This is required so (Closed)

Created:
11 years, 4 months ago by Aaron Boodman
Modified:
9 years, 6 months ago
Reviewers:
Matt Perry
CC:
chromium-reviews_googlegroups.com, DaveMoore
Visibility:
Public.

Description

Change the way json_schema.js is loaded. This is required so that ChromeOS can use extension-style bindings without polluting the global scope of webpages. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24174 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24217

Patch Set 1 #

Total comments: 3

Patch Set 2 : New approach using chromeHidden #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -43 lines) Patch
M chrome/chrome.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/extensions/extension_process_bindings.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + chrome/renderer/extensions/js_only_v8_extensions.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/renderer/extensions/js_only_v8_extensions.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/renderer/render_thread.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/renderer_resources.grd View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extension_process_bindings.js View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/json_schema.js View 14 chunks +32 lines, -29 lines 0 comments Download
M chrome/test/render_view_test.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Aaron Boodman
11 years, 4 months ago (2009-08-24 08:13:18 UTC) #1
Matt Perry
http://codereview.chromium.org/173263/diff/1/2 File chrome/renderer/extensions/extension_process_bindings.cc (right): http://codereview.chromium.org/173263/diff/1/2#newcode137 Line 137: if (!try_catch.Exception().IsEmpty()) Add a DCHECK for this with ...
11 years, 4 months ago (2009-08-24 19:11:43 UTC) #2
Aaron Boodman
Ready for another look.
11 years, 4 months ago (2009-08-24 21:27:49 UTC) #3
Matt Perry
11 years, 4 months ago (2009-08-24 21:29:59 UTC) #4
Nice.  LGTM

Powered by Google App Engine
This is Rietveld 408576698