Modifies readline() to behave in the same way as it does in TraceMonkey.

Modifies readline() to behave in the same way as it does in TraceMonkey.

[abdulla, 2009-09-03 03:37:20]

Just pinging about this change. It's currently holding up the language shootout
from using V8.

[diakopter, 2009-09-03 03:46:54]

I disagree.. how is it holding it up?  What's wrong with wrapping readline() in
try/catch, as I did in
http://shootout.alioth.debian.org/u32/benchmark.php?test=regexdna&lang=all

(where, incidentally, JavaScript V8 beats all other implementations)

[Christian Plesner Hansen, 2009-09-03 06:14:41]

Note that just creating the code review doesn't cause me to get a notification,
you have to send out an email manually.  That's why I haven't responded.

The code change lgtm.  Is this behavior compatible with the other
implementations?

[abdulla, 2009-09-06 03:21:40]

After talking with Matt and having a look at what TraceMonkey does, I've updated
the code. This should hopefully satisfy everyone's needs.

[Christian Plesner Hansen, 2009-09-07 09:26:32]

More comments.  This seems to return 'null' when retrieving the empty string,
not just on EOF.  Is that intentional?

http://codereview.chromium.org/173262/diff/6001/7001
File src/d8.cc (right):

http://codereview.chromium.org/173262/diff/6001/7001#newcode185
Line 185: i::SmartPointer<char> line(new char[size]);
Smart pointers need their contents to be allocated using NewArray.  Also,
wouldn't it be easier to just use i::ReadLine from utils.h?

[abdulla, 2009-09-07 12:21:15]

Yup, that is intentional. I'm returning Null to mimic the behaviour of
TraceMonkey:
http://hg.mozilla.org/tracemonkey/file/45772700955a/js/src/shell/js.cpp#l998

http://codereview.chromium.org/173262/diff/6001/7001
File src/d8.cc (right):

http://codereview.chromium.org/173262/diff/6001/7001#newcode185
Line 185: i::SmartPointer<char> line(new char[size]);
On 2009/09/07 09:26:35, Christian Plesner Hansen wrote:
> Smart pointers need their contents to be allocated using NewArray.  Also,
> wouldn't it be easier to just use i::ReadLine from utils.h?

Done.

[Christian Plesner Hansen, 2009-09-07 12:39:03]

Landed in http://code.google.com/p/v8/source/detail?r=2838.