Move gtk_settings_get_default() call to the UI thread.

Move gtk_settings_get_default() call to the UI thread.

BUG=19971
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24034

[Lei Zhang, 2009-08-21 20:59:12]

LGTM

[Evan Martin, 2009-08-21 21:13:24]

http://codereview.chromium.org/173216/diff/1/2
File base/mime_util_linux.cc (right):

http://codereview.chromium.org/173216/diff/1/2#newcode50
Line 50: std::string gtk_theme_name_;
Comment on this.  (E.g. where it comes from, when it' valid, etc.)

http://codereview.chromium.org/173216/diff/1/2#newcode566
Line 566:
Singleton<MimeUtilConstants>::get()->gtk_theme_name_.assign(gtk_theme_name);
Is there a possibility of a race between this set and the other thread accessing
it?

http://codereview.chromium.org/173216/diff/1/4
File chrome/browser/icon_loader.cc (right):

http://codereview.chromium.org/173216/diff/1/4#newcode13
Line 13: #include <gtk/gtk.h>
this isn't a necessary include

[willchan no longer on Chromium, 2009-08-21 21:20:37]

LGTM, thanks for the fix.

http://codereview.chromium.org/173216/diff/1/2
File base/mime_util_linux.cc (right):

http://codereview.chromium.org/173216/diff/1/2#newcode566
Line 566:
Singleton<MimeUtilConstants>::get()->gtk_theme_name_.assign(gtk_theme_name);
On 2009/08/21 21:13:24, Evan Martin wrote:
> Is there a possibility of a race between this set and the other thread
accessing
> it?

There shouldn't be.  This code gets executed before the task gets posted to the
file thread, so there is no other thread's task to race against yet.

[Evan Stade, 2009-08-21 21:34:25]

http://codereview.chromium.org/173216/diff/1/2
File base/mime_util_linux.cc (right):

http://codereview.chromium.org/173216/diff/1/2#newcode50
Line 50: std::string gtk_theme_name_;
On 2009/08/21 21:13:24, Evan Martin wrote:
> Comment on this.  (E.g. where it comes from, when it' valid, etc.) 

Done.

http://codereview.chromium.org/173216/diff/1/2#newcode566
Line 566:
Singleton<MimeUtilConstants>::get()->gtk_theme_name_.assign(gtk_theme_name);
On 2009/08/21 21:20:37, willchan wrote:
> On 2009/08/21 21:13:24, Evan Martin wrote:
> > Is there a possibility of a race between this set and the other thread
> accessing
> > it?
> 
> There shouldn't be.  This code gets executed before the task gets posted to
the
> file thread, so there is no other thread's task to race against yet.

Will is correct, and the comment in the header instructs future callers to make
sure DetectGtkTheme is called _first_.

http://codereview.chromium.org/173216/diff/1/4
File chrome/browser/icon_loader.cc (right):

http://codereview.chromium.org/173216/diff/1/4#newcode13
Line 13: #include <gtk/gtk.h>
On 2009/08/21 21:13:24, Evan Martin wrote:
> this isn't a necessary include

oopsies.