Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issue 1732022: VBoot Reference: Make kernel_config a 4K byte block, and move it after the verified boot block. (Closed)

Created:
10 years, 8 months ago by gauravsh
Modified:
9 years, 6 months ago
Reviewers:
Bill Richardson
CC:
chromium-os-reviews_chromium.org, gauravsh
Base URL:
ssh://git@chromiumos-git/chromeos
Visibility:
Public.

Description

VBoot Reference: Make kernel_config a 4K byte block, and move it after the verified boot block. The kernel_config is now stored as a 4K binary block instead of the kconfig_options structure that was being used before. Since the verified boot code doesn't care what kernel config options are (other than the length of the kernel image and for verifying them before the rest of kernel), it is ok to keep them as a blackbox. This CL also changes the verified boot kernel layout - VBlock Data followed by Kernel Config followed by the Kernel Image. This will allow them to be stored separately, or as a concatenated block (for easy memory mapping during kernel load). This should ease the process of generating a layout for verified boot kernel images which is also compatible with legacy BIOSes that don't support this mechanism. Finally, there is also a new firmware API function to determine the size of a kernel verified boot block, given a pointer to its beginning (for determining the offset to the kernel config and data).

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+187 lines, -181 lines) Patch
M src/platform/vboot_reference/tests/kernel_image_tests.c View 1 chunk +2 lines, -2 lines 0 comments Download
M src/platform/vboot_reference/tests/kernel_splicing_tests.c View 1 chunk +1 line, -1 line 0 comments Download
M src/platform/vboot_reference/tests/test_common.c View 2 chunks +3 lines, -7 lines 0 comments Download
M src/platform/vboot_reference/utility/include/kernel_utility.h View 1 chunk +2 lines, -2 lines 1 comment Download
M src/platform/vboot_reference/utility/kernel_utility.cc View 5 chunks +13 lines, -45 lines 0 comments Download
M src/platform/vboot_reference/vkernel/include/kernel_image_fw.h View 3 chunks +17 lines, -17 lines 0 comments Download
M src/platform/vboot_reference/vkernel/kernel_image.c View 11 chunks +48 lines, -75 lines 0 comments Download
M src/platform/vboot_reference/vkernel/kernel_image_fw.c View 5 chunks +101 lines, -32 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
gauravsh
10 years, 8 months ago (2010-04-29 02:17:28 UTC) #1
Bill Richardson
10 years, 7 months ago (2010-04-29 18:14:43 UTC) #2
LGTM

http://codereview.chromium.org/1732022/diff/1/5
File src/platform/vboot_reference/utility/include/kernel_utility.h (right):

http://codereview.chromium.org/1732022/diff/1/5#newcode73
src/platform/vboot_reference/utility/include/kernel_utility.h:73: uint64_t
kernel_len_;
No objection, but I kind of doubt that the kernel will ever be larger than 4G.

Powered by Google App Engine
This is Rietveld 408576698