Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(848)

Issue 1732019: Switch to vectors instead of bare char* arrays. (Closed)

Created:
10 years, 8 months ago by Florian Loitsch
Modified:
9 years, 7 months ago
Reviewers:
William Hesse
CC:
v8-dev
Visibility:
Public.

Description

Switch to vectors instead of bare char* arrays. Committed: http://code.google.com/p/v8/source/detail?r=4546

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -19 lines) Patch
M src/conversions.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/fast-dtoa.h View 1 chunk +5 lines, -1 line 0 comments Download
M src/fast-dtoa.cc View 4 chunks +8 lines, -4 lines 0 comments Download
M test/cctest/test-fast-dtoa.cc View 5 chunks +14 lines, -12 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Florian Loitsch
10 years, 8 months ago (2010-04-28 19:31:27 UTC) #1
William Hesse
10 years, 7 months ago (2010-04-29 09:23:32 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698