Issue 173189: Prepare to push to trunk. We are now working on version 1.3.7

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 173189: Prepare to push to trunk. We are now working on version 1.3.7 (Closed)

Created:
11 years, 4 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Prepare to push to trunk. We are now working on version 1.3.7. Committed: http://code.google.com/p/v8/source/detail?r=2738

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -1 line)			Patch
	M	ChangeLog	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download
	M	src/version.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

LGTM http://codereview.chromium.org/173189/diff/1/3 File ChangeLog (right): http://codereview.chromium.org/173189/diff/1/3#newcode4 Line 4: embedding host can force execution of JavaScript. ...

11 years, 4 months ago (2009-08-21 09:19:05 UTC) #2

Søren Thygesen Gjesse

11 years, 4 months ago (2009-08-21 09:24:56 UTC) #3

http://codereview.chromium.org/173189/diff/1/3
File ChangeLog (right):

http://codereview.chromium.org/173189/diff/1/3#newcode4
Line 4: embedding host can force execution of JavaScript.
On 2009/08/21 09:19:05, Mads Ager wrote:
> force termination of ...
> 
> Maybe just remove the second sentence?

Done.

http://codereview.chromium.org/173189/diff/1/3#newcode15
Line 15: Fixed build on Ubuntu with GCC 4.4.
On 2009/08/21 09:19:05, Mads Ager wrote:
> I would leave this out since I have not been able to verify the fix.

Done.

Expand Messages | Collapse Messages