Remove uses of deprecated version of FileUtil::ResolveShortcut....

Remove uses of deprecated version of FileUtil::ResolveShortcut.

BUG=None
TEST=run base_unittests.exe

[Evan Martin, 2009-08-21 16:35:50]

Can you remove the wstring version of ResolveShortcut, then?

[Avi (use Gerrit), 2009-08-21 16:36:43]

http://codereview.chromium.org/173181/diff/1/2
File base/file_util_unittest.cc (right):

http://codereview.chromium.org/173181/diff/1/2#newcode715
Line 715: FilePath link_file_path = link_file;
Why do you do this? link_file_str existed because link_file was a FilePath and
the API only took a string. Now that the API takes a FilePath, just pass
link_file in. No copy needed.

http://codereview.chromium.org/173181/diff/1/3
File net/url_request/url_request_file_job.cc (right):

http://codereview.chromium.org/173181/diff/1/3#newcode283
Line 283: FilePath new_path = file_path_;
Why copy? Why not just pass file_path_ in directly?

[tfarina (gmail-do not use), 2009-08-21 17:02:34]

http://codereview.chromium.org/173181/diff/1/2
File base/file_util_unittest.cc (right):

http://codereview.chromium.org/173181/diff/1/2#newcode715
Line 715: FilePath link_file_path = link_file;
On 2009/08/21 16:36:43, Avi wrote:
> Why do you do this? link_file_str existed because link_file was a FilePath and
> the API only took a string. Now that the API takes a FilePath, just pass
> link_file in. No copy needed.
I thought it was intended.
Done

http://codereview.chromium.org/173181/diff/1/3
File net/url_request/url_request_file_job.cc (right):

http://codereview.chromium.org/173181/diff/1/3#newcode283
Line 283: FilePath new_path = file_path_;
On 2009/08/21 16:36:43, Avi wrote:
> Why copy? Why not just pass file_path_ in directly?
Is there no problem changing the the value of file_path_ here?  I think is not
good changing the value here.

[Avi (use Gerrit), 2009-08-21 17:04:19]

http://codereview.chromium.org/173181/diff/1/3
File net/url_request/url_request_file_job.cc (right):

http://codereview.chromium.org/173181/diff/1/3#newcode283
Line 283: FilePath new_path = file_path_;
On 2009/08/21 17:02:34, tfarina wrote:
> I think is not
> good changing the value here.

Sorry, didn't see the pass-by-pointer.

[Evan Martin, 2009-08-21 21:40:35]

LGTM otherwise

http://codereview.chromium.org/173181/diff/1004/9
File base/file_util.h (left):

http://codereview.chromium.org/173181/diff/1004/9#oldcode233
Line 233: // the URL into path. If path is a invalid .LNK file, return false.
Is "URL" correct here?  I don't know this API...

[tfarina (gmail-do not use), 2009-08-21 21:48:15]

http://codereview.chromium.org/173181/diff/1004/9
File base/file_util.h (left):

http://codereview.chromium.org/173181/diff/1004/9#oldcode233
Line 233: // the URL into path. If path is a invalid .LNK file, return false.
On 2009/08/21 21:40:35, Evan Martin wrote:
> Is "URL" correct here?  I don't know this API...
I think it's correct, because it is about the url that exists in .lnk file. I
think Avi would comment here.

[Avi (use Gerrit), 2009-08-22 19:24:47]

http://codereview.chromium.org/173181/diff/1004/9
File base/file_util.h (left):

http://codereview.chromium.org/173181/diff/1004/9#oldcode233
Line 233: // the URL into path. If path is a invalid .LNK file, return false.
On 2009/08/21 21:48:15, tfarina wrote:
> I think it's correct, because it is about the url that exists in .lnk file. I
> think Avi would comment here.

I'm probably not the person to consult about windows LNK files, but the
documentation seems to indicate that LNK files are only used for local
shortcuts. If we look at the callers:

url_request_file_job: used to indicate a "redirection" in a filesystem request
shell_dialogs_win: used to follow shortcuts for selected files

Evan appears to be correct; a rephrasing of this comment is definitely in order.

[tfarina (gmail-do not use), 2009-08-22 20:11:56]

On 2009/08/22 19:24:47, Avi wrote:
> http://codereview.chromium.org/173181/diff/1004/9
> File base/file_util.h (left):
> 
> http://codereview.chromium.org/173181/diff/1004/9#oldcode233
> Line 233: // the URL into path. If path is a invalid .LNK file, return false.
> On 2009/08/21 21:48:15, tfarina wrote:
> > I think it's correct, because it is about the url that exists in .lnk file.
I
> > think Avi would comment here.
> 
> I'm probably not the person to consult about windows LNK files, but the
> documentation seems to indicate that LNK files are only used for local
> shortcuts. If we look at the callers:
> 
> url_request_file_job: used to indicate a "redirection" in a filesystem request
> shell_dialogs_win: used to follow shortcuts for selected files
> 
> Evan appears to be correct; a rephrasing of this comment is definitely in
order.
Right, as a new comment was necessary, I rewrote the comment trying to give a
better idea of what it really does, please take another look.

[Avi (use Gerrit), 2009-08-24 20:44:21]

LG! Nice comment.

[tfarina (gmail-do not use), 2009-08-24 21:14:10]

On 2009/08/24 20:44:21, Avi wrote:
> LG! Nice comment.
Thanks Avi!
Ah I don't have commit access, so when you have a time can you land this to me?

[Evan Martin, 2009-08-24 21:17:05]

i'll do it.

[Evan Martin, 2009-08-25 01:52:10]

committed