Issue 173123: Don't use -fomit-frame-pointer to build Mac V8

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 173123: Don't use -fomit-frame-pointer to build Mac V8 (Closed)

Created:
11 years, 4 months ago by Mark Mentovai

Modified:
9 years, 7 months ago

Reviewers:
Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Don't use -fomit-frame-pointer to build Mac V8. The Chrome crash reporting system can't currently process stacks produced by gcc -fomit-frame-pointer properly. The drawback outweighs the 2% performance improvement. Once the crash reporting system is able to handle this optimization, it should be revisited. Committed: http://code.google.com/p/v8/source/detail?r=2733

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	tools/gyp/v8.gyp	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kasper Lund

11 years, 4 months ago (2009-08-20 14:42:12 UTC) #2

LGTM. Do we have feature request for the crash reporting system to be able to
handle this? If so, maybe we should add a note there about this issue.

Expand Messages | Collapse Messages