Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 173116: Fix an ASSERT in the scanner (Closed)

Created:
11 years, 4 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
Reviewers:
Kasper Lund
CC:
v8-dev
Visibility:
Public.

Description

Fix an ASSERT in the scanner. The assert when performing a push back on a two byte string was wrong. Added a small regression test. Committed: http://code.google.com/p/v8/source/detail?r=2735

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -3 lines) Patch
M src/scanner.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/scanner.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/test-api.cc View 1 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Thygesen Gjesse
11 years, 4 months ago (2009-08-20 11:31:40 UTC) #1
Kasper Lund
LGTM. http://codereview.chromium.org/173116/diff/1/4 File test/cctest/test-api.cc (right): http://codereview.chromium.org/173116/diff/1/4#newcode7159 Line 7159: const char *ascii_sources[] = { const char ...
11 years, 4 months ago (2009-08-20 11:33:09 UTC) #2
Søren Thygesen Gjesse
11 years, 4 months ago (2009-08-21 06:25:33 UTC) #3
http://codereview.chromium.org/173116/diff/1/4
File test/cctest/test-api.cc (right):

http://codereview.chromium.org/173116/diff/1/4#newcode7159
Line 7159: const char *ascii_sources[] = {
On 2009/08/20 11:33:09, Kasper Lund wrote:
> const char * -> const char*

Done.

http://codereview.chromium.org/173116/diff/1/4#newcode7167
Line 7167: int i = 0;
On 2009/08/20 11:33:09, Kasper Lund wrote:
> for loop?

Done.

Powered by Google App Engine
This is Rietveld 408576698