Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Unified Diff: chrome/browser/cocoa/bookmark_bar_folder_window.mm

Issue 1731001: UI review follow-up for m5 bookmark bar deliverables... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/cocoa/bookmark_bar_folder_window.mm
===================================================================
--- chrome/browser/cocoa/bookmark_bar_folder_window.mm (revision 45053)
+++ chrome/browser/cocoa/bookmark_bar_folder_window.mm (working copy)
@@ -4,7 +4,9 @@
#import "chrome/browser/cocoa/bookmark_bar_folder_window.h"
+#import "base/logging.h"
#import "base/scoped_nsobject.h"
+#import "chrome/browser/cocoa/bookmark_bar_folder_controller.h"
#import "third_party/GTM/AppKit/GTMNSColor+Luminance.h"
#import "third_party/GTM/AppKit/GTMNSBezierPath+RoundRect.h"
@@ -72,3 +74,20 @@
}
@end
+
+
+@implementation BookmarkBarFolderWindowScrollView
+
+// We want "draw background" of the NSScrollView in the xib to be NOT
+// checked. That allows us to round the bottom corners of the folder
+// window. However that also allows some scrollWheel: events to leak
+// into the NSWindow behind it (even in a different application).
+// Better to plug the scroll leak than to round corners for M5.
+- (void)scrollWheel:(NSEvent *)theEvent {
+ DCHECK([[[self window] windowController]
+ respondsToSelector:@selector(scrollWheel:)]);
+ [[[self window] windowController] scrollWheel:theEvent];
+}
+
+
+@end
« no previous file with comments | « chrome/browser/cocoa/bookmark_bar_folder_window.h ('k') | chrome/browser/cocoa/bookmark_bar_folder_window_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698