Setup script for O3D plugin installer. This is the installer that we will giv...

Setup script for O3D plugin installer. This is the installer that we will give to users that don't have a .deb or .rpm compatible distro. Creating a new issue since the last one was broken.

[noah, 2009-08-19 21:09:48]

FYI, this is a continuation of:

http://codereview.chromium.org/174080

This previous issue got hosed somehow, so I opened a new issue for this.

[Tristan Schmelcher, 2009-08-19 21:16:05]

Looking good! Just little nitpicks now.

http://codereview.chromium.org/173081/diff/1/2
File installer/linux/generic/setup.sh (right):

http://codereview.chromium.org/173081/diff/1/2#newcode84
Line 84: echo -n "Copying plugins to $O3D_DIR..."
The three libs are not plugins, so this text is misleading. How about just
"Installing files to $O3D_DIR..." ?

http://codereview.chromium.org/173081/diff/1/2#newcode89
Line 89: echo -n "Creating symlinks to plugins..."
Should be singular, i.e. "plugin".

http://codereview.chromium.org/173081/diff/1/2#newcode122
Line 122: echo "nspluginwrapper not found. Without nspluginwrapper you will be"
Looks like this will end up being printed on the same line as the "Attempting
..." text above, which will probably look ugly. Should put an embedded newline
in this string to compensate, e.g.:

echo "
nspluginwrapper not found ..."

In fact, you don't need the second echo command below, because you can just put
in another embedded newline.

http://codereview.chromium.org/173081/diff/1/2#newcode123
Line 123: echo "unable to use O3D in 64-bit browsers. Continue installation?
(y/n)"
It's convention to make the "n" a capital to denote that it's the default. So
"(y/N)".

[noah, 2009-08-19 21:39:56]

Still dealing with issues getting new CL uploaded, but incorporated these
comments.

http://codereview.chromium.org/173081/diff/1/2
File installer/linux/generic/setup.sh (right):

http://codereview.chromium.org/173081/diff/1/2#newcode84
Line 84: echo -n "Copying plugins to $O3D_DIR..."
On 2009/08/19 21:16:06, Tristan Schmelcher wrote:
> The three libs are not plugins, so this text is misleading. How about just
> "Installing files to $O3D_DIR..." ?

Done.

http://codereview.chromium.org/173081/diff/1/2#newcode89
Line 89: echo -n "Creating symlinks to plugins..."
On 2009/08/19 21:16:06, Tristan Schmelcher wrote:
> Should be singular, i.e. "plugin".

Done.

http://codereview.chromium.org/173081/diff/1/2#newcode122
Line 122: echo "nspluginwrapper not found. Without nspluginwrapper you will be"
On 2009/08/19 21:16:06, Tristan Schmelcher wrote:
> Looks like this will end up being printed on the same line as the "Attempting
> ..." text above, which will probably look ugly. Should put an embedded newline
> in this string to compensate, e.g.:
> 
> echo "
> nspluginwrapper not found ..."
> 
> In fact, you don't need the second echo command below, because you can just
put
> in another embedded newline.

Done.

http://codereview.chromium.org/173081/diff/1/2#newcode123
Line 123: echo "unable to use O3D in 64-bit browsers. Continue installation?
(y/n)"
On 2009/08/19 21:16:06, Tristan Schmelcher wrote:
> It's convention to make the "n" a capital to denote that it's the default. So
> "(y/N)".

Done.