Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 173072: Suppress slider thumb jumping around during seeking... (Closed)

Created:
11 years, 4 months ago by Alpha Left Google
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com, scherkus (not reviewing), fbarchard, brettw, awong
Visibility:
Public.

Description

Suppress slider thumb jumping around during seeking BUG=19396 TEST=Open a video, seek to any position, the thumb should stops a bit and then goes forward from there. Preventing the slider thumb from jumping around after seek by freezing the clock until we get a valid time update from the audio renderer. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23937

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 20

Patch Set 4 : '' #

Total comments: 3

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -15 lines) Patch
M media/base/buffers.h View 1 chunk +3 lines, -0 lines 0 comments Download
A media/base/buffers.cc View 6 1 chunk +13 lines, -0 lines 0 comments Download
M media/base/clock_impl.cc View 1 2 3 4 2 chunks +5 lines, -0 lines 0 comments Download
M media/base/pipeline_impl.h View 1 3 1 chunk +5 lines, -0 lines 0 comments Download
M media/base/pipeline_impl.cc View 1 2 3 8 chunks +40 lines, -7 lines 0 comments Download
M media/filters/ffmpeg_audio_decoder.cc View 3 3 chunks +19 lines, -8 lines 0 comments Download
M media/filters/ffmpeg_demuxer.cc View 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M media/filters/ffmpeg_video_decoder.cc View 3 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Alpha Left Google
no test yet, just shows the idea..
11 years, 4 months ago (2009-08-19 19:36:13 UTC) #1
Alpha Left Google
this code is good for testing again.
11 years, 4 months ago (2009-08-20 06:26:28 UTC) #2
scherkus (not reviewing)
fix initial comments, but looking good! http://codereview.chromium.org/173072/diff/21/22 File media/base/clock.h (right): http://codereview.chromium.org/173072/diff/21/22#newcode44 Line 44: static const ...
11 years, 4 months ago (2009-08-20 21:40:46 UTC) #3
Alpha Left Google
http://codereview.chromium.org/173072/diff/21/22 File media/base/clock.h (right): http://codereview.chromium.org/173072/diff/21/22#newcode44 Line 44: static const base::TimeDelta kInvalidTimestamp; On 2009/08/20 21:40:46, scherkus ...
11 years, 4 months ago (2009-08-20 22:23:58 UTC) #4
scherkus (not reviewing)
http://codereview.chromium.org/173072/diff/1014/1015 File media/base/clock_impl.cc (right): http://codereview.chromium.org/173072/diff/1014/1015#newcode35 Line 35: if (time.InMicroseconds() < 0) { the only invalid ...
11 years, 4 months ago (2009-08-20 23:19:44 UTC) #5
Alpha Left Google
http://codereview.chromium.org/173072/diff/1014/1015 File media/base/clock_impl.cc (right): http://codereview.chromium.org/173072/diff/1014/1015#newcode35 Line 35: if (time.InMicroseconds() < 0) { On 2009/08/20 23:19:44, ...
11 years, 4 months ago (2009-08-20 23:36:36 UTC) #6
Alpha Left Google
updated..
11 years, 4 months ago (2009-08-21 01:04:49 UTC) #7
scherkus (not reviewing)
11 years, 4 months ago (2009-08-21 01:07:39 UTC) #8
LGTM

Powered by Google App Engine
This is Rietveld 408576698