Fix download shelf item overflow on os x.

Fix download shelf item overflow on os x.

This was regressed by the subview layout refactoring.

BUG=14672
TEST=download several items, resize window, make sure that no download item ever overlaps the "Show all downloads" link on the right.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24683

[rohitrao (ping after 24h), 2009-08-19 13:02:20]

Hey,
  I didn't understand the problem or solution on a quick readthrough, so I'll
give this a more careful look later tonight.

[Nico, 2009-08-25 18:27:22]

Ping. See the bug for the problem description. Let me know if I should explain
the solution.

[rohitrao (ping after 24h), 2009-08-27 15:44:44]

As we spoke about yesterday, the only property I need is for the height to be 0.
 Will things work again if you keep the same origin/width and simply change the
height of the view?

http://codereview.chromium.org/173048/diff/5/1004
File chrome/browser/cocoa/download_shelf_controller.mm (right):

http://codereview.chromium.org/173048/diff/5/1004#newcode58
Line 58: // This calls show:, so it needs to be last.
This comment no longer applies, since I removed the Show() call.

[Nico, 2009-08-27 22:25:42]

Resetting the height to 0 works fine, too. Take another look?

[Nico, 2009-08-27 22:25:51]

Resetting the height to 0 works fine, too. Take another look?

http://codereview.chromium.org/173048/diff/5/1004
File chrome/browser/cocoa/download_shelf_controller.mm (right):

http://codereview.chromium.org/173048/diff/5/1004#newcode58
Line 58: // This calls show:, so it needs to be last.
On 2009/08/27 15:44:44, rohitrao wrote:
> This comment no longer applies, since I removed the Show() call.

Done.

[rohitrao (ping after 24h), 2009-08-27 22:28:09]

http://codereview.chromium.org/173048/diff/3003/2002
File chrome/browser/cocoa/download_shelf_controller.mm (right):

http://codereview.chromium.org/173048/diff/3003/2002#newcode63
Line 63: [[self view] setFrame:NSMakeRect(0, 0, 1000, 0)];
This section of code probably isn't supposed to be here =)  Hopefully things
will still work even after you remove it.

[Nico, 2009-08-27 22:37:09]

http://codereview.chromium.org/173048/diff/3003/2002
File chrome/browser/cocoa/download_shelf_controller.mm (right):

http://codereview.chromium.org/173048/diff/3003/2002#newcode63
Line 63: [[self view] setFrame:NSMakeRect(0, 0, 1000, 0)];
Heh.

Yes, still seems to work. Lucky me.

[rohitrao (ping after 24h), 2009-08-27 22:40:08]

LGTM