Issue 173033: Stub out sqlite3Preload when using system library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 173033: Stub out sqlite3Preload when using system library. (Closed)

Created:
11 years, 4 months ago by agl

Modified:
9 years, 7 months ago

Reviewers:
tony

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Stub out sqlite3Preload when using system library. We have a local patch to sqlite which adds a sqlite3Preload function. In the interim before this patch is upstreamed, we add this stub function to allow us to compile with a system sqlite. (Reported by fta)

Patch Set 1 #

Patch Set 2 : ... #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -0 lines)			Patch
	M	chrome/common/sqlite_utils.h	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
	M	chrome/common/sqlite_utils.cc	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

tony

11 years, 4 months ago (2009-08-19 00:41:54 UTC) #2

LGTM.  I doubt this will ever get upstreamed (brettw wrote it for Firefox since
the 2.0 days), but that's not a big deal.  I'm also pretty sure that this will
significantly hurt start up time, but I guess the distros are ok with that.

Expand Messages | Collapse Messages