Port more browser focus tests to linux....

Port more browser focus tests to linux.

Added a new test to make sure clicking sets focus, since I changed a lot of tests to programatically set focus instead of using clicking.

Also set the actual time on our synthetic key events. I'm still not sure this is necessary but would like to avoid subtle bugs.

Also get rid of the NineBox constructor that takes a theme provider and convert its callers to use cairo directly or the other NineBox constructor. This change was necessary because theme providers could go stale and then the NineBox would cause seg faults. Also, it was only being used for single images... and UniBox just sounds wrong.

Also fix extension shelf to paint its image with the correct x/y (noticeable only with certain themes). Remove the notification observer stuff from the extension shelf, as I don't think there is any action to be taken when the theme changes.

BUG=19076
BUG=19659
TEST=all the ported interactive ui tests (as well as all the already-working tests) pass.
TEST=(Linux) things still render correctly (frame image, drop shadows, find box, extension shelf)


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23732

[Evan Stade, 2009-08-19 00:00:22]

testing this on windows now.

[Evan Stade, 2009-08-19 00:05:23]

Adding more reviewers (I have been picking on Tony a lot lately, and Jay should
probably review the BrowserFocusTest bits anyway)

[tony, 2009-08-19 00:46:41]

http://codereview.chromium.org/173030/diff/1/2
File base/keyboard_codes_linux.h (right):

http://codereview.chromium.org/173030/diff/1/2#newcode88
Line 88: VKEY_A = GDK_a,
This looked scary, but upon closer inspection, it doesn't look like we used
these values anywhere.  Why do you need them now?

http://codereview.chromium.org/173030/diff/1/9
File chrome/browser/gtk/browser_window_gtk.cc (right):

http://codereview.chromium.org/173030/diff/1/9#newcode501
Line 501: static ThemeProvider* theme_provider_for_static_images =
theme_provider;
Ick, how about we just get rid of the 4 nine boxes and use the cairo commands
directly?  It's only like 2 cairo calls.

http://codereview.chromium.org/173030/diff/1/9#newcode548
Line 548: if (!custom_frame_border.get() || need_to_refresh_static_images) {
In this case, I think we don't need to use the theme provider ninebox (these are
just alpha'ed images for the frame and themes can't override them).  If we use
the regular NineBox, I don't think this will be an issue.

http://codereview.chromium.org/173030/diff/1/9#newcode576
Line 576: static ThemeProvider* theme_provider_for_static_images =
theme_provider;
Same thing, we can just do a direct cairo call here.

http://codereview.chromium.org/173030/diff/1/10
File chrome/browser/gtk/nine_box.h (right):

http://codereview.chromium.org/173030/diff/1/10#newcode66
Line 66: // Call g_object_ref() on all the images.
Is this still necessary for browser tests?

[Evan Stade, 2009-08-19 01:01:10]

removing NineBox stuff as per offline convo with Tony.

http://codereview.chromium.org/173030/diff/1/2
File base/keyboard_codes_linux.h (right):

http://codereview.chromium.org/173030/diff/1/2#newcode88
Line 88: VKEY_A = GDK_a,
On 2009/08/19 00:46:42, tony wrote:
> This looked scary, but upon closer inspection, it doesn't look like we used
> these values anywhere.  Why do you need them now?

Although it didn't make it into this change I was playing around with
SendKeyPress{NotifyWhenDone}() and this change is needed to make it work
correctly for letter keys.

http://codereview.chromium.org/173030/diff/1/10
File chrome/browser/gtk/nine_box.h (right):

http://codereview.chromium.org/173030/diff/1/10#newcode66
Line 66: // Call g_object_ref() on all the images.
On 2009/08/19 00:46:42, tony wrote:
> Is this still necessary for browser tests?

no, it just seemed safer for assorted corner cases, e.g. during shutdown.

[Evan Stade, 2009-08-19 04:42:12]

updated

[tony, 2009-08-19 17:47:26]

yay, LGTM!

http://codereview.chromium.org/173030/diff/1028/1036
File chrome/browser/gtk/browser_window_gtk.cc (right):

http://codereview.chromium.org/173030/diff/1028/1036#newcode555
Line 555: GdkPixbuf* top_center =
theme_provider->GetPixbufNamed(IDR_CONTENT_TOP_CENTER);
Nit: 80 cols.