Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Issue 173026: Move IDMap back to base/ where it is needed. (Closed)

Created:
11 years, 4 months ago by Paweł Hajdan Jr.
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, michaeln
Visibility:
Public.

Description

Move IDMap back to base/ where it is needed. TEST=Covered by base_unittests. BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23709

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
M base/base.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
A + base/id_map.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + base/id_map_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_plugin_browsing_context.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/render_process_host.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome.gyp View 3 chunks +1 line, -3 lines 0 comments Download
M chrome/common/app_cache/app_cache_context_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/app_cache/app_cache_dispatcher_host.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/db_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/db_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/message_router.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/audio_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/render_view.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Paweł Hajdan Jr.
11 years, 4 months ago (2009-08-18 23:01:48 UTC) #1
darin (slow to review)
LGTM
11 years, 4 months ago (2009-08-18 23:07:05 UTC) #2
brettw
11 years, 4 months ago (2009-08-18 23:32:28 UTC) #3
LGTM2

Powered by Google App Engine
This is Rietveld 408576698