Issue 173003: Fix IA32 build when not using native regexp compiler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 173003: Fix IA32 build when not using native regexp compiler. (Closed)

Created:
11 years, 4 months ago by Feng Qian

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein, Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix IA32 build when not using native regexp compiler. Committed: http://code.google.com/p/v8/source/detail?r=2709

Patch Set 1 #

Total comments: 2

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -0 lines)			Patch
	M	src/ia32/regexp-macro-assembler-ia32.h	View		2 chunks	+9 lines, -0 lines	1 comment	Download
	M	src/ia32/regexp-macro-assembler-ia32.cc	View		2 chunks	+4 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

11 years, 4 months ago (2009-08-19 05:19:57 UTC) #2

http://codereview.chromium.org/173003/diff/1/2
File src/ia32/regexp-macro-assembler-ia32.cc (right):

http://codereview.chromium.org/173003/diff/1/2#newcode41
Line 41: #ifdef V8_NATIVE_REGEXP
If we don't use native regexps, this file should not be compiled at all. The
scons and gyp files should work like this *cross fingers*. How are you building
to have a problem here?

http://codereview.chromium.org/173003/diff/1/3
File src/ia32/regexp-macro-assembler-ia32.h (right):

http://codereview.chromium.org/173003/diff/1/3#newcode34
Line 34: #ifndef V8_NATIVE_REGEXP
If we don't use native regexps then we shouldn't include
regexp-macro-assembler-ia32.h at all. If we do, it is an error, but it should be
fixed by ifdef'ing the include instead.

Expand Messages | Collapse Messages