Windows/Views: delete native bookmark manager code.

Windows/Views: delete native bookmark manager code.

Context menu code still needs cleanup/refactoring.
String resources still need to be deleted.

BUG=38908
TEST=everything still works

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45776

[viettrungluu, 2010-04-27 05:37:47]

Still to do:
- rework the bookmark context menu controllers
- figure out whether we want bookmark creation to select the new bookmark in the
tabbed bookmark manager (and thus whether we still need BookmarkEditor::Handler)
- delete string resources

I'll do those in separate CLs.

[sky, 2010-04-27 15:42:51]

http://codereview.chromium.org/1730015/diff/1/2
File chrome/browser/bookmarks/bookmark_context_menu_controller.cc (right):

http://codereview.chromium.org/1730015/diff/1/2#newcode213
chrome/browser/bookmarks/bookmark_context_menu_controller.cc:213:
BookmarkEditor::EditDetails(), editor_config, NULL);
Can we remove the last arg from BookmarkEditor::Show now?

http://codereview.chromium.org/1730015/diff/1/3
File chrome/browser/bookmarks/bookmark_folder_editor_controller.cc (right):

http://codereview.chromium.org/1730015/diff/1/3#newcode70
chrome/browser/bookmarks/bookmark_folder_editor_controller.cc:70: //    
BookmarkManager::SelectInTree(profile_, node);
I believe this was only used when created from the bookmark manager, which won't
happen anymore so the define and this code can safely be removed.

http://codereview.chromium.org/1730015/diff/1/11
File chrome/browser/views/bookmark_manager_view.cc (left):

http://codereview.chromium.org/1730015/diff/1/11#oldcode13
chrome/browser/views/bookmark_manager_view.cc:13: #include
"chrome/browser/bookmarks/bookmark_folder_tree_model.h"
you should be able to remove bookmark_folder_tree_model, and
bookmark_table_model as well.

[viettrungluu, 2010-04-28 00:11:39]

Thanks.

http://codereview.chromium.org/1730015/diff/1/2
File chrome/browser/bookmarks/bookmark_context_menu_controller.cc (right):

http://codereview.chromium.org/1730015/diff/1/2#newcode213
chrome/browser/bookmarks/bookmark_context_menu_controller.cc:213:
BookmarkEditor::EditDetails(), editor_config, NULL);
On 2010/04/27 15:42:52, sky wrote:
> Can we remove the last arg from BookmarkEditor::Show now?

Let me punt on this momentarily, since this change would affect a number of
files on multiple platforms (esp. since I'll then have to figure out which
objects have a BookmarkEditor::Handler* for the sole purpose of calling Show()
with it).

http://codereview.chromium.org/1730015/diff/1/3
File chrome/browser/bookmarks/bookmark_folder_editor_controller.cc (right):

http://codereview.chromium.org/1730015/diff/1/3#newcode70
chrome/browser/bookmarks/bookmark_folder_editor_controller.cc:70: //    
BookmarkManager::SelectInTree(profile_, node);
On 2010/04/27 15:42:52, sky wrote:
> I believe this was only used when created from the bookmark manager, which
won't
> happen anymore so the define and this code can safely be removed.

Done.

http://codereview.chromium.org/1730015/diff/1/11
File chrome/browser/views/bookmark_manager_view.cc (left):

http://codereview.chromium.org/1730015/diff/1/11#oldcode13
chrome/browser/views/bookmark_manager_view.cc:13: #include
"chrome/browser/bookmarks/bookmark_folder_tree_model.h"
On 2010/04/27 15:42:52, sky wrote:
> you should be able to remove bookmark_folder_tree_model, and
> bookmark_table_model as well.

Done.

[sky, 2010-04-28 00:13:46]

LGTM