Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1730012: build: Get rid of scary /dev/sdb defaults in scripts. (Closed)

Created:
10 years, 8 months ago by Daniel Erat
Modified:
9 years, 7 months ago
Reviewers:
sosa
CC:
chromium-os-reviews_chromium.org, Nick Sanders
Base URL:
ssh://git@chromiumos-git/chromeos
Visibility:
Public.

Description

build: Get rid of scary /dev/sdb defaults in scripts. Choosing a default device is no good; the user should tell us where the image should be written. BUG=none TEST=wrote an image

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -16 lines) Patch
M src/scripts/build_image View 1 chunk +1 line, -1 line 0 comments Download
M src/scripts/image_to_usb.sh View 2 chunks +5 lines, -15 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Daniel Erat
10 years, 8 months ago (2010-04-24 02:03:06 UTC) #1
sosa
10 years, 8 months ago (2010-04-24 02:37:50 UTC) #2
lgtm.

Powered by Google App Engine
This is Rietveld 408576698