Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Unified Diff: src/cpu-profiler.cc

Issue 1730003: Patch trunk to version 2.2.4.2, pulling in change 4464. (Closed) Base URL: http://v8.googlecode.com/svn/trunk/
Patch Set: Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/version.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/cpu-profiler.cc
===================================================================
--- src/cpu-profiler.cc (revision 4464)
+++ src/cpu-profiler.cc (working copy)
@@ -420,6 +420,10 @@
generator_ = new ProfileGenerator(profiles_);
processor_ = new ProfilerEventsProcessor(generator_);
processor_->Start();
+ // Enable stack sampling.
+ // It is important to have it started prior to logging, see issue 683:
+ // http://code.google.com/p/v8/issues/detail?id=683
+ reinterpret_cast<Sampler*>(Logger::ticker_)->Start();
// Enumerate stuff we already have in the heap.
if (Heap::HasBeenSetup()) {
Logger::LogCodeObjects();
@@ -427,8 +431,6 @@
Logger::LogFunctionObjects();
Logger::LogAccessorCallbacks();
}
- // Enable stack sampling.
- reinterpret_cast<Sampler*>(Logger::ticker_)->Start();
}
}
« no previous file with comments | « no previous file | src/version.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698