Issue 1729015: Ground work for making appcache work in workers....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1729015: Ground work for making appcache work in workers.... (Closed)

Created:
10 years, 8 months ago by michaeln

Modified:
9 years, 7 months ago

Reviewers:
Andrew T Wilson (Slow)

CC:
chromium-reviews, darin-cc_chromium.org, dpranke+watch_chromium.org, pam+watch_chromium.org, jam

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Ground work for making appcache work in workers. Put in place a noop impl of createApplicationCacheHost() on all WebCommonWorkerClient subclasses. That factory method is soon to be added to the WebKit::WebCommonWorkerClient class as a pure virtual. Adding these methods in advance so it builds when that pure virtual shows up later. BUG=39368 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45642

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -0 lines)			Patch
	M	chrome/worker/webworkerclient_proxy.h	View	1	2 chunks	+8 lines, -0 lines	0 comments	Download
	M	webkit/tools/test_shell/test_web_worker.h	View	1	2 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

michaeln

http://codereview.chromium.org/1729015/diff/1/2 File webkit/tools/test_shell/test_web_worker.h (right): http://codereview.chromium.org/1729015/diff/1/2#newcode17 webkit/tools/test_shell/test_web_worker.h:17: class WebURL; doh... need some forward declarations here!

10 years, 8 months ago (2010-04-24 20:12:48 UTC) #2

Andrew T Wilson (Slow)

10 years, 8 months ago (2010-04-25 16:28:38 UTC) #3

LGTM assuming you fix the compilation errors :) If it requires anything other
than a simple forward decl, feel free to bounce it back to me for another peek.

http://codereview.chromium.org/1729015/diff/1/2
File webkit/tools/test_shell/test_web_worker.h (right):

http://codereview.chromium.org/1729015/diff/1/2#newcode23
webkit/tools/test_shell/test_web_worker.h:23: class TestWebWorker : public
WebKit::WebWorker,
That's correct. I think dimich@ is going to try to change this in the distant
future, but it requires adding multi-thread support to V8 so that's not
happening for a while. In any case, stubbing out APIs here is the correct thing
to do.

Expand Messages | Collapse Messages