Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 17281: This is a rename of the term 'Greasemonkey' to 'user script' in Chromium. (Closed)

Created:
11 years, 11 months ago by Aaron Boodman
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

This is a rename of the term 'Greasemonkey' to 'user script' in Chromium. I'm doing this to avoid confusion with the Firefox version of Greasemonkey and also because 'user script' is really the correct generic term. At the same time, I also moved user_script_master* into extensions/ because I want these two pieces to get closer and closer such that standalone user scripts are just a very small extension. Also extensions will be relying on most of the user script code.

Patch Set 1 #

Patch Set 2 : detect move #

Total comments: 2

Patch Set 3 : Fix indent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -206 lines) Patch
M chrome/browser/browser.scons View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser.vcproj View 2 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/greasemonkey_master.h View 1 3 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/greasemonkey_master.cc View 1 10 chunks +17 lines, -17 lines 0 comments Download
M chrome/browser/greasemonkey_master_unittest.cc View 1 7 chunks +17 lines, -17 lines 0 comments Download
M chrome/browser/net/chrome_url_request_context.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/profile.h View 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/profile.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/render_process_host.h View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/render_process_host.cc View 9 chunks +15 lines, -17 lines 0 comments Download
M chrome/chrome.xcodeproj/project.pbxproj View 1 2 15 chunks +16 lines, -16 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/notification_types.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/render_messages_internal.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/greasemonkey_slave.h View 1 5 chunks +17 lines, -17 lines 0 comments Download
M chrome/renderer/greasemonkey_slave.cc View 1 7 chunks +15 lines, -15 lines 0 comments Download
M chrome/renderer/greasemonkey_slave_unittest.cc View 1 4 chunks +13 lines, -13 lines 0 comments Download
M chrome/renderer/render_thread.h View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/renderer/render_thread.cc View 6 chunks +9 lines, -9 lines 0 comments Download
M chrome/renderer/render_view.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/render_view.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M chrome/renderer/renderer.scons View 2 chunks +1 line, -1 line 0 comments Download
M chrome/renderer/renderer.vcproj View 2 chunks +8 lines, -8 lines 0 comments Download
M chrome/test/testing_profile.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/unit/unit_tests.scons View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/unit/unittests.vcproj View 1 chunk +6 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Aaron Boodman
11 years, 11 months ago (2009-01-08 20:59:09 UTC) #1
Erik does not do reviews
Any reason why you didn't rename the greasemonkey* filenames in this CL as well? http://codereview.chromium.org/17281/diff/202/79 ...
11 years, 11 months ago (2009-01-09 19:02:30 UTC) #2
Aaron Boodman
On 2009/01/09 19:02:30, Erik Kay wrote: > Any reason why you didn't rename the greasemonkey* ...
11 years, 11 months ago (2009-01-09 19:32:10 UTC) #3
Aaron Boodman
http://codereview.chromium.org/17281/diff/202/79 File chrome/common/chrome_switches.cc (right): http://codereview.chromium.org/17281/diff/202/79#newcode337 Line 337: const wchar_t kEnableUserScripts[] = L"enable-user-scripts"; On 2009/01/09 19:02:30, ...
11 years, 11 months ago (2009-01-09 19:33:42 UTC) #4
Erik does not do reviews
11 years, 11 months ago (2009-01-09 19:37:30 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698