Fix dragging a tab out of a window when the only tabs left behind are phantom...

Fix dragging a tab out of a window when the only tabs left behind are phantom tabs.
BUG=42698
TEST=per bug. Might want to re-test dragging single tabs and dragging tabs out when there are pinned tabs (not phantoms).

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45982

[pink (ping after 24hrs), 2010-04-28 21:08:43]

Trung, I don't really like the idea of exposing phantom tabs to
TabWindowController, but it has to have some concept of this state. Can you
suggest a better name for this method?

Maybe something like "windowHasNoReasonToBeAlive"?

[viettrungluu, 2010-04-28 21:15:10]

Maybe we should opt for the opposite of the "phantom" concept instead? So maybe
-hasLiveTabs?

LGTM otherwise.

On 2010/04/28 21:08:43, pink wrote:
> Trung, I don't really like the idea of exposing phantom tabs to
> TabWindowController, but it has to have some concept of this state. Can you
> suggest a better name for this method?
> 
> Maybe something like "windowHasNoReasonToBeAlive"?

[pink (ping after 24hrs), 2010-04-28 21:24:30]

Changed to hasLiveTabs. Want to give it another quick look to make
sure I didn't mess anything up?

On Wed, Apr 28, 2010 at 5:15 PM,  <viettrungluu@chromium.org> wrote:
> Maybe we should opt for the opposite of the "phantom" concept instead? So
> maybe
> -hasLiveTabs?
>
> LGTM otherwise.
>
> On 2010/04/28 21:08:43, pink wrote:
>>
>> Trung, I don't really like the idea of exposing phantom tabs to
>> TabWindowController, but it has to have some concept of this state. Can
>> you
>> suggest a better name for this method?
>
>> Maybe something like "windowHasNoReasonToBeAlive"?
>
>
>
> http://codereview.chromium.org/1727013/show
>



-- 
Mike Pinkerton
Mac Weenie
pinkerton@google.com

[viettrungluu, 2010-04-28 21:48:42]

lgtm