Issue 1727009: Always use opaque frame for extension app windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1727009: Always use opaque frame for extension app windows (Closed)

Created:
10 years, 8 months ago by Aaron Boodman

Modified:
9 years, 6 months ago

Reviewers:
Glen Murphy, Peter Kasting, rafaelw

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
git://codf21.jail/chromium.git

Visibility:
Public.

Always use opaque frame for extension app windows. It hasn't been implemented for the glass frame yet. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45874

Total comments: 1

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -1 line)			Patch
M	chrome/browser/views/frame/browser_frame_win.cc	View	1 chunk	+3 lines, -0 lines	1 comment	Download
M	chrome/browser/views/frame/opaque_browser_frame_view.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/views/frame/opaque_browser_frame_view.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/views/tabs/tab_strip.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (0 generated)

rafaelw

lgtm. i suggest double-checking with peter or glen on the change in tab_strip

10 years, 8 months ago (2010-04-28 00:27:47 UTC) #3

Peter Kasting

LGTM. I confess I don't fully understand "AlwaysUseCustomFrame()", Ben or Glen added that one. (The ...

10 years, 8 months ago (2010-04-28 04:45:17 UTC) #4

+glen