Issue 1725011: GTK: Add a drag icon for site icon drags.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1725011: GTK: Add a drag icon for site icon drags. (Closed)

Created:
10 years, 8 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
tony, Elliot Glaysher

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

GTK: Add a drag icon for site icon drags. BUG=42147 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45846

Patch Set 1 #

Total comments: 2

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+61 lines, -7 lines)			Patch
	M	chrome/browser/gtk/location_bar_view_gtk.h	View		2 chunks	+5 lines, -0 lines	0 comments	Download
	M	chrome/browser/gtk/location_bar_view_gtk.cc	View		7 chunks	+56 lines, -7 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

http://www/~estade/no_crawl/lidrag.png note this only works for compositing window managers. Other WMs are unaffected. I think ...

10 years, 8 months ago (2010-04-28 00:28:08 UTC) #1

Elliot Glaysher

LGTM http://codereview.chromium.org/1725011/diff/1/2 File chrome/browser/gtk/location_bar_view_gtk.cc (right): http://codereview.chromium.org/1725011/diff/1/2#newcode1003 chrome/browser/gtk/location_bar_view_gtk.cc:1003: // Paint the favicon. We can't do this ...

10 years, 8 months ago (2010-04-28 00:31:09 UTC) #2

Evan Stade

10 years, 8 months ago (2010-04-28 00:33:50 UTC) #3

http://codereview.chromium.org/1725011/diff/1/2
File chrome/browser/gtk/location_bar_view_gtk.cc (right):

http://codereview.chromium.org/1725011/diff/1/2#newcode1003
chrome/browser/gtk/location_bar_view_gtk.cc:1003: // Paint the favicon.
On 2010/04/28 00:31:09, Elliot Glaysher wrote:
> We can't do this with cairo? Tears.

well, this does use cairo underneath, but using canvas is more convenient

Expand Messages | Collapse Messages