Issue 1725007: Simplify the Observer pattern used in the BrowserList.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1725007: Simplify the Observer pattern used in the BrowserList. (Closed)

Created:
10 years, 8 months ago by tfarina (gmail-do not use)

Modified:
9 years, 7 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews, ben+cc_chromium.org, brettw-cc_chromium.org

Visibility:
Public.

Description

Simplify the Observer pattern used in the BrowserList. BUG=None TEST=None Patch from Thiago Farina <thiago.farina@gmail.com>; Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45963

Patch Set 2 : back Compact to protected section #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -48 lines)			Patch
M	base/observer_list.h	View	1	2 chunks	+3 lines, -5 lines	0 comments	Download
M	chrome/browser/browser_list.h	View		4 chunks	+13 lines, -19 lines	0 comments	Download
M	chrome/browser/browser_list.cc	View		8 chunks	+12 lines, -24 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

LGTM http://codereview.chromium.org/1725007/diff/2001/3001 File base/observer_list.h (right): http://codereview.chromium.org/1725007/diff/2001/3001#newcode152 base/observer_list.h:152: void Compact() { Nit: You made Compact() public ...

10 years, 8 months ago (2010-04-28 21:34:10 UTC) #2

tfarina (gmail-do not use)

http://codereview.chromium.org/1725007/diff/2001/3001 File base/observer_list.h (right): http://codereview.chromium.org/1725007/diff/2001/3001#newcode152 base/observer_list.h:152: void Compact() { On 2010/04/28 21:34:11, Peter Kasting wrote: ...

10 years, 8 months ago (2010-04-29 02:53:51 UTC) #3

Landed in r45963.

Expand Messages | Collapse Messages

Issue 1725007: Simplify the Observer pattern used in the BrowserList. (Closed)

Description

Patch Set 1 : " #

Patch Set 2 : back Compact to protected section #

Messages