Issue 17244: - moved the defaults/prefs handling for settings during layout tests into...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17244: - moved the defaults/prefs handling for settings during layout tests into... (Closed)

Created:
11 years, 11 months ago by TVL

Modified:
9 years, 7 months ago

Reviewers:
pink (ping after 24hrs), awalker, Amanda Walker

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

- moved the defaults/prefs handling for settings during layout tests into functions so it's a little easier to follow. - added color sync profile mgmt during layout tests so more images will match. - added signal handlers (like webkit) to do our best to get the color profile reset if we crash. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7729

Patch Set 1 #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+150 lines, -56 lines)			Patch
	M	webkit/tools/test_shell/test_shell_mac.mm	View		2 chunks	+150 lines, -56 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Amanda Walker

11 years, 11 months ago (2009-01-07 21:48:06 UTC) #2

LGTM.  Thanks for breaking all that out into static methods--that'll make this
easier to integrate with some other changes I'm working on.

Expand Messages | Collapse Messages