Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 17244: - moved the defaults/prefs handling for settings during layout tests into... (Closed)

Created:
11 years, 11 months ago by TVL
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

- moved the defaults/prefs handling for settings during layout tests into functions so it's a little easier to follow. - added color sync profile mgmt during layout tests so more images will match. - added signal handlers (like webkit) to do our best to get the color profile reset if we crash. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7729

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -56 lines) Patch
M webkit/tools/test_shell/test_shell_mac.mm View 2 chunks +150 lines, -56 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
TVL
11 years, 11 months ago (2009-01-07 21:26:22 UTC) #1
Amanda Walker
11 years, 11 months ago (2009-01-07 21:48:06 UTC) #2
LGTM.  Thanks for breaking all that out into static methods--that'll make this
easier to integrate with some other changes I'm working on.

Powered by Google App Engine
This is Rietveld 408576698