Issue 1723019: Fixed bug in samples conversion introduced by WebGL-related changes and...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1723019: Fixed bug in samples conversion introduced by WebGL-related changes and... (Closed)

Created:
10 years, 7 months ago by Ken Russell (switch to Gerrit)

Modified:
9 years, 7 months ago

Reviewers:
greggman

CC:
o3d-review_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/o3d/

Visibility:
Public.

Description

Fixed bug in samples conversion introduced by WebGL-related changes and caught by Linux try bots. Need to specify a different output than the non-WebGL target for the same asset, because otherwise multithreaded builds choose one or the other target to execute. BUG=none TEST=reran build Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45837

Patch Set 1 #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -2 lines)			Patch
	M	samples/samples_gen.py	View		2 chunks	+10 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages