Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1723014: Remove svn:executable property from more files that don't need it. (Closed)

Created:
10 years, 8 months ago by Lei Zhang
Modified:
9 years, 7 months ago
Reviewers:
tony
CC:
chromium-reviews, ncarter (slow), ben+cc_chromium.org, Erik does not do reviews, idana, Aaron Boodman, arv (Not doing code reviews), pam+watch_chromium.org, tim (not reviewing), brettw-cc_chromium.org, Paweł Hajdan Jr., davemoore+watch_chromium.org
Visibility:
Public.

Description

Remove svn:executable property from more files that don't need it. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45659

Patch Set 1 #

Patch Set 2 : remove bat file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-123 lines, --123 lines) Patch
M chrome/app/theme/app_launcher_button.png View Binary file 0 comments Download
M chrome/app/theme/back_Template.pdf View Binary file 0 comments Download
M chrome/app/theme/find_next_Template.pdf View Binary file 0 comments Download
M chrome/app/theme/find_prev_Template.pdf View Binary file 0 comments Download
M chrome/app/theme/forward_Template.pdf View Binary file 0 comments Download
M chrome/app/theme/go_Template.pdf View Binary file 0 comments Download
M chrome/app/theme/home_Template.pdf View Binary file 0 comments Download
M chrome/app/theme/login_default.png View Binary file 0 comments Download
M chrome/app/theme/login_other.png View Binary file 0 comments Download
M chrome/app/theme/mediaplayer_playlist.png View Binary file 0 comments Download
M chrome/app/theme/menu_chrome_Template.pdf View Binary file 0 comments Download
M chrome/app/theme/menu_chrome_rtl_Template.pdf View Binary file 0 comments Download
M chrome/app/theme/menu_page_Template.pdf View Binary file 0 comments Download
M chrome/app/theme/menu_page_rtl_Template.pdf View Binary file 0 comments Download
M chrome/app/theme/omnibox_history.pdf View Binary file 0 comments Download
M chrome/app/theme/omnibox_http.pdf View Binary file 0 comments Download
M chrome/app/theme/omnibox_https_invalid.pdf View Binary file 0 comments Download
M chrome/app/theme/omnibox_https_valid.pdf View Binary file 0 comments Download
M chrome/app/theme/omnibox_https_warning.pdf View Binary file 0 comments Download
M chrome/app/theme/omnibox_more.pdf View Binary file 0 comments Download
M chrome/app/theme/omnibox_search.pdf View Binary file 0 comments Download
M chrome/app/theme/omnibox_star.pdf View Binary file 0 comments Download
M chrome/app/theme/omnibox_star_lit.pdf View Binary file 0 comments Download
M chrome/app/theme/reload_Template.pdf View Binary file 0 comments Download
M chrome/app/theme/stop_Template.pdf View Binary file 0 comments Download
M chrome/app/theme/tab_alpha_new_tab.png View Binary file 0 comments Download
M chrome/app/theme/tab_new_tab_shadow.png View Binary file 0 comments Download
M chrome/browser/chromeos/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/debugger/devtools_window.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/debugger/devtools_window.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/extensions/extension_install_ui.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/geolocation/geolocation_content_settings_map.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/geolocation/geolocation_content_settings_map.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/geolocation/geolocation_content_settings_map_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/resources/about_os_credits.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/resources/calendar_app/128.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/resources/calendar_app/24.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/resources/calendar_app/32.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/resources/calendar_app/48.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/resources/docs_app/128.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/resources/docs_app/24.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/resources/docs_app/32.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/resources/docs_app/48.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/resources/gmail_app/128.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/resources/gmail_app/24.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/resources/gmail_app/32.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/resources/gmail_app/48.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/resources/notification_1line.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/resources/notification_2line.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/resources/notification_icon.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/sync/engine/store_timestamps_command.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/sync/engine/store_timestamps_command.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/sync/protocol/sync.proto View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/sync/resources/gaia_login.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/tab_contents/web_drag_utils_win.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/tab_contents/web_drag_utils_win.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/views/options/content_filter_page_view.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/views/options/content_filter_page_view.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/views/options/customize_sync_window_view.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/views/options/customize_sync_window_view.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/chrome_renderer.gypi View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/api/extension_api.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/css/ApiRefStyles.css View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/browserAction/make_page_red/manifest.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/browserAction/set_icon_path/manifest.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/browserAction/set_page_color/manifest.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/history/showHistory/manifest.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/tabs/screenshot/manifest.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/tabs/screenshot/screenshot.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/fx/bg.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/fx/bg.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/fx/content.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/fx/icon.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/fx/manifest.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/fx/options.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/gdocs/README View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/gdocs/background.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/gdocs/chrome_ex_oauth.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/gdocs/chrome_ex_oauth.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/gdocs/chrome_ex_oauthsimple.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/gdocs/manifest.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/gdocs/options.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/gdocs/popup.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/gmail/_locales/ar/messages.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/gmail/_locales/bg/messages.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/gmail/_locales/ca/messages.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/gmail/_locales/cs/messages.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/gmail/_locales/da/messages.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/gmail/_locales/de/messages.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/gmail/_locales/el/messages.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/gmail/_locales/en_GB/messages.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/gmail/_locales/es_419/messages.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/gmail/_locales/et/messages.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/gmail/_locales/fi/messages.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/gmail/_locales/fil/messages.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/gmail/_locales/fr/messages.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/gmail/_locales/he/messages.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/gmail/_locales/hi/messages.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/gmail/_locales/hr/messages.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/gmail/_locales/hu/messages.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/gmail/_locales/id/messages.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/gmail/_locales/it/messages.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/gmail/_locales/ja/messages.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/gmail/_locales/ko/messages.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/gmail/_locales/lt/messages.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/gmail/_locales/lv/messages.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/gmail/_locales/nb/messages.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/gmail/_locales/nl/messages.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/gmail/_locales/pl/messages.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/gmail/_locales/pt_BR/messages.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/gmail/_locales/pt_PT/messages.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/gmail/_locales/ro/messages.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/gmail/_locales/ru/messages.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/gmail/_locales/sk/messages.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/gmail/_locales/sl/messages.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/gmail/_locales/sr/messages.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/gmail/_locales/sv/messages.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/gmail/_locales/th/messages.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/gmail/_locales/tr/messages.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/gmail/_locales/uk/messages.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/gmail/_locales/vi/messages.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/gmail/_locales/zh_CN/messages.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/gmail/_locales/zh_TW/messages.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/irc/README.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/irc/app/manifest.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/irc/conf/irc.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/irc/conf/jetty.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/irc/conf/webdefault.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/irc/servlet/WEB-INF/web.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/irc/servlet/addChannel.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/irc/servlet/addServer.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/irc/servlet/index.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/irc/servlet/irc.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/irc/servlet/jstemplate/jsevalcontext.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/irc/servlet/jstemplate/jstemplate.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/irc/servlet/jstemplate/util.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/irc/servlet/notification.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/irc/servlet/src/org/chromium/IRCProxyWebSocket.java View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/irc/servlet/styles.css View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/irc/servlet/util.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/mappy/background.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/mappy/manifest.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/mappy/mappy_content_script.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/tutorials/getstarted/manifest.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/images/code_labs_logo.gif View Binary file 0 comments Download
M chrome/common/extensions/docs/images/hello-world-1.gif View Binary file 0 comments Download
M chrome/common/extensions/docs/images/hello-world-2.gif View Binary file 0 comments Download
M chrome/common/extensions/docs/images/hw-1.gif View Binary file 0 comments Download
M chrome/common/extensions/docs/images/hw-2.gif View Binary file 0 comments Download
M chrome/common/extensions/docs/images/hw-3.gif View Binary file 0 comments Download
M chrome/common/extensions/docs/images/news.gif View Binary file 0 comments Download
M chrome/common/extensions/docs/images/package-success.gif View Binary file 0 comments Download
M chrome/common/extensions/docs/images/themes-1.gif View Binary file 0 comments Download
M chrome/common/extensions/docs/images/themes-2.gif View Binary file 0 comments Download
M chrome/common/extensions/docs/images/themes-3.gif View Binary file 0 comments Download
M chrome/common/extensions/docs/images/toolsmenu.gif View Binary file 0 comments Download
M chrome/common/extensions/docs/images/update-success.gif View Binary file 0 comments Download
M chrome/common/extensions/docs/js/api_page_generator.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/js/bootstrap.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/static/experimental.processes.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/static/i18n-messages.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/static/pageAction.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/static/tut_oauth.html View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lei Zhang
Tony's on irc at dinner time. Tony gets to sanity check the file list. :)
10 years, 8 months ago (2010-04-27 01:34:45 UTC) #1
tony
There's a .bat file in the list. Should that have the executable bit? Otherwise, LGTM.
10 years, 8 months ago (2010-04-27 01:40:26 UTC) #2
Lei Zhang
10 years, 8 months ago (2010-04-27 01:49:19 UTC) #3 
On 2010/04/27 01:40:26, tony wrote:
> There's a .bat file in the list.  Should that have the executable bit?
> 
> Otherwise, LGTM.

Thanks for spotting that. Removed and committing.

Powered by Google App Engine
This is Rietveld 408576698