Issue 17221: Checking in media_player project, which is used for standalone media testing.

Issue 17221: Checking in media_player project, which is used for standalone media testing. (Closed)

Created:
11 years, 11 months ago by scherkus (not reviewing)

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review), cpu_(ooo_6.6-7.5)

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Checking in media_player project, which is used for standalone media testing. It does nothing yet and is only included in media.sln.

Patch Set 1 #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+172 lines, -6 lines)			Patch
A	media/build/media_player.vcproj	View	1 chunk	+153 lines, -0 lines	0 comments	Download
M	media/media.sln	View	3 chunks	+10 lines, -6 lines	0 comments	Download
A	media/player/player.cc	View	1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

scherkus (not reviewing)

I'm going to move over our standalone media player, since it's been indispensable for testing ...

11 years, 11 months ago (2009-01-07 00:17:16 UTC) #1

cpu_(ooo_6.6-7.5)

On 2009/01/07 00:17:16, scherkus wrote: > I'm going to move over our standalone media player, ...

11 years, 11 months ago (2009-01-07 00:42:22 UTC) #2

scherkus (not reviewing)

On 2009/01/07 00:42:22, cpu wrote: > On 2009/01/07 00:17:16, scherkus wrote: > > I'm going ...

11 years, 11 months ago (2009-01-08 21:45:04 UTC) #3

cpu_(ooo_6.6-7.5)

11 years, 11 months ago (2009-01-08 23:50:20 UTC) #4

lgtm

I can add the code to create the window in windows. Just let me know.


On 2009/01/08 21:45:04, scherkus wrote:
> On 2009/01/07 00:42:22, cpu wrote:
> > On 2009/01/07 00:17:16, scherkus wrote:
> > > I'm going to move over our standalone media player, since it's been
> > > indispensable for testing our code!
> > 
> > is it not platform dependent? or does player.cc have a bunch of platform
> > specific #ifdefs ?
> > 
> > Do you have it already on perforce, so I can see what is the end result?
> 
> Any additional feedback on this change?  I'll defer including SDL or other
> third_party libraries until later.  It might be easier in the end to just
write
> a tiny bit of platform code to open a window to draw on.

Expand Messages | Collapse Messages