chrome/browser/extensions/extension_host.cc - Issue 172120: Revert "Revert "Allow DOMUI pages to call window.open(), giving DOMUI privileges to the new""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_host.cc

Issue 172120: Revert "Revert "Allow DOMUI pages to call window.open(), giving DOMUI privileges to the new"" (Closed)

Patch Set: Created 11 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_host.cc

diff --git a/chrome/browser/extensions/extension_host.cc b/chrome/browser/extensions/extension_host.cc

index 60aa0d3a1e8a4c72457dbaae2a500cb5ddf84a56..8690e6ac9e47c7a64258265510f0978eb64ba048 100644

--- a/chrome/browser/extensions/extension_host.cc

+++ b/chrome/browser/extensions/extension_host.cc

@@ -232,7 +232,7 @@ void ExtensionHost::CreateNewWindow(int route_id,

base::WaitableEvent* modal_dialog_event) {

delegate_view_helper_.CreateNewWindow(

route_id, modal_dialog_event, render_view_host()->process()->profile(),

- site_instance());

+ site_instance(), DOMUIFactory::GetDOMUIType(url_));

}

void ExtensionHost::CreateNewWidget(int route_id, bool activatable) {