Issue 17211: Make Mac bitmaps use BGRA to match the MD5 hash Apple uses in its WebKit expe...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17211: Make Mac bitmaps use BGRA to match the MD5 hash Apple uses in its WebKit expe... (Closed)

Created:
11 years, 11 months ago by pink (ping after 24hrs)

Modified:
9 years, 7 months ago

Reviewers:
TVL, Amanda Walker, Amanda Walker (Google)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Make Mac bitmaps use BGRA to match the MD5 hash Apple uses in its WebKit expectations. Use a png for "missingImage" because it has the color range to match the TIFF used by Apple in its expectations. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7619

Patch Set 1 #

Total comments: 3

Patch Set 2 : '' #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -10 lines)			Patch
M	skia/ext/bitmap_platform_device_mac.cc	View	1	1 chunk	+5 lines, -2 lines	0 comments	Download
M	webkit/tools/test_shell/mac/TestShell.xcodeproj/project.pbxproj	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	webkit/tools/test_shell/resources/README.txt	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A	webkit/tools/test_shell/resources/missingImage.png	View		Binary file		0 comments	Download
M	webkit/tools/test_shell/test_shell.cc	View		2 chunks	+11 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Amanda Walker

lgtm http://codereview.chromium.org/17211/diff/1/3 File skia/ext/bitmap_platform_device_mac.cc (right): http://codereview.chromium.org/17211/diff/1/3#newcode176 Line 176: color_space, trailing whitespace http://codereview.chromium.org/17211/diff/1/3#newcode177 Line 177: kCGImageAlphaPremultipliedFirst ...

11 years, 11 months ago (2009-01-06 21:17:03 UTC) #3

TVL

11 years, 11 months ago (2009-01-06 21:17:49 UTC) #4

http://codereview.chromium.org/17211/diff/1/3
File skia/ext/bitmap_platform_device_mac.cc (right):

http://codereview.chromium.org/17211/diff/1/3#newcode178
Line 178: kCGBitmapByteOrder32Host);
do we need to worry about the shift masks in skia's headers not matching this?

Expand Messages | Collapse Messages