Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 172044: Fix issue 427: JS tick processor now works out-of-the-box for Chromium on Windows. (Closed)

Created:
11 years, 4 months ago by mnaganov (inactive)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix issue 427: JS tick processor now works out-of-the-box for Chromium on Windows. MSVS names '.map' file using only module's name, so both 'a.exe' and 'a.dll' will have 'a.map' file. To distinguish an originating module, we're now checking for image base which is always 00400000 for .exe files, and not 00400000 for .dlls. Verified that windows-tick-processor can now process logs from Chromium using .map file generated for 'chrome.dll', an that it still works for V8's 'shell.exe'. Committed: http://code.google.com/p/v8/source/detail?r=2699

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -4 lines) Patch
M test/mjsunit/tools/tickprocessor.js View 1 chunk +72 lines, -0 lines 0 comments Download
M tools/tickprocessor.js View 2 chunks +29 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
mnaganov (inactive)
11 years, 4 months ago (2009-08-17 12:47:15 UTC) #1
Søren Thygesen Gjesse
11 years, 4 months ago (2009-08-17 13:37:31 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698