Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1720001: Added Google Cache Invalidation library to DEPS and got it to compile (Closed)

Created:
10 years, 8 months ago by akalin
Modified:
9 years, 7 months ago
Reviewers:
ncarter (slow), ghc
CC:
chromium-reviews, adya_google.com
Visibility:
Public.

Description

Added Google Cache Invalidation library to DEPS and got it to compile with the Chromium libraries. Added some override files to make it work, the biggest of which defines NewPermanentCallback() overrides that base/callback.h doesn't handle. BUG=34646 TEST=added unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45412

Patch Set 1 #

Patch Set 2 : Fixed lint errors #

Patch Set 3 : Synced to head #

Messages

Total messages: 5 (0 generated)
akalin
+nick and +ghc for review. At last, importing this into the Chromium tree!
10 years, 8 months ago (2010-04-20 21:20:29 UTC) #1
akalin
Ping! On 2010/04/20 21:20:29, akalin wrote: > +nick and +ghc for review. > > At ...
10 years, 8 months ago (2010-04-22 21:45:46 UTC) #2
ghc
Looks good to me. (There seem to be some lint warnings on some of the ...
10 years, 8 months ago (2010-04-22 22:09:00 UTC) #3
ncarter (slow)
LGTM
10 years, 8 months ago (2010-04-23 01:06:21 UTC) #4
akalin (wrong akalin)
10 years, 8 months ago (2010-04-23 01:49:11 UTC) #5
Yeah, that's just an artifact of how 'git cl' uploads files.  The
missing newlines actually aren't there on commit.

On Thu, Apr 22, 2010 at 3:09 PM,  <ghc@google.com> wrote:
> Looks good to me.  (There seem to be some lint warnings on some of the
> headers
> -- not sure if that's important.)
>
>
> http://codereview.chromium.org/1720001/show
>



-- 
Frederick Akalin
Software Engineer

Powered by Google App Engine
This is Rietveld 408576698