Issue 1719019: GPU service interprets glFinish as glFlush....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1719019: GPU service interprets glFinish as glFlush.... (Closed)

Created:
10 years, 8 months ago by apatrick_chromium

Modified:
9 years, 7 months ago

Reviewers:
greggman

CC:
chromium-reviews, apatrick_chromium, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

GPU service interprets glFinish as glFlush. This is so the single threaded GPU service does not get delayed executing glFinish, which could prevent progress in rendering all other GL contexts. Instead just issue a glFlush to ensure that the pending commands will be processed in the future. From a client side perspective the semantics of glFlush and glFinish are still different. glFlush is asynchronous whereas glFinish is synchronous. The latter waits for the service to acknowledge that it has issued the glFlush. glFinish can therefore be used to synchronize multiple threads that are issuing commands to GL contexts that share a common namespace. TEST=trybots BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45724

Patch Set 1 #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -3 lines)			Patch
M	gpu/command_buffer/build_gles2_cmd_buffer.py	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder_autogen.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder_unittest_1_autogen.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages