AU: Class to perform delta updates.

src/platform/update_engine/delta_diff_generator.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROMEOS_PLATFORM_UPDATE_ENGINE_DELTA_DIFF_GENERATOR_H__
 #define CHROMEOS_PLATFORM_UPDATE_ENGINE_DELTA_DIFF_GENERATOR_H__
 
 #include <string>
 #include <vector>
 #include "base/basictypes.h"
@@ skipping 93 matching lines @@
   // will set to be a file that contains "XY".
   static bool ReorderDataBlobs(DeltaArchiveManifest* manifest,
                                const std::string& data_blobs_path,
                                const std::string& new_data_blobs_path);
 
  private:
   // This should never be constructed
   DISALLOW_IMPLICIT_CONSTRUCTORS(DeltaDiffGenerator);
 };
 
+namespace {
+const char* const kBsdiffPath = "/usr/bin/bsdiff";

[Daniel Erat, 2010/04/23 17:47:25]

Same objection as in delta_performer.h here -- I don't think that you should be
defining constants at the bottom of a header file (why at the bottom?  why in an
anon namespace?).

[adlr, 2010/04/23 20:50:17]

Sorry, I think I just threw this in while writing code. It seemed like, at least
for integer constant, this might be more efficient since they could be inlined.
the anon namespace was the c++ conversion of 'static', which is how i would have
done it in c.

anyway, changed to non-anon namespace and to just declarations with the
definitions in the corresponding .cc file.

+const char* const kBspatchPath = "/usr/bin/bspatch";
+const char* const kDeltaMagic = "CrAU";
+}
+
 };  // namespace chromeos_update_engine
 
 #endif  // CHROMEOS_PLATFORM_UPDATE_ENGINE_DELTA_DIFF_GENERATOR_H__